-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transparency option #540
base: v4.9.0
Are you sure you want to change the base?
Add transparency option #540
Conversation
Opinions on these translation keys? The linux/windows one would be used depending on which platform you're on.
|
Should be all set, needs testing on windows and macos and then a review. |
Confirmed working on windows after minor issues, just need test on macos. |
Require discord restart for transparency change Move transparency button move readSettingsSync to src/util.mts At platform specific notices Fix transparency on Windows BrowserWindow rework MacOS Auto-Maximize
Fixed some issues, looks like blur isn't possible with neither the native setBackgroundMaterial nor @pyke/vibe on canary (electron 28) |
This pr is not ready to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nuh uh
If anyone would like to take this over please just let me know. |
Example video of it working: https://zipline.eastarcti.ca/u/KgFiYH.mp4 :root {
--window-background-material: "acrylic";
--window-background-color: #00000000;
}
html, body {
background: transparent;
} Example theme using acrylic https://github.com/EastArctica/replugged-nord-transparent/releases/tag/v1.0.3 |
maybe we can do something listening the resize event from the BrowserWindow object something like this: window.on('resize', () => {
window.webContents.send('resize-event');
}); we also have the maximize unmaximize and minimize events |
@Ren0X1 This probably isn't what you meant but while looking into it the latest commit changes the way maximize/unmaximize is done in a few ways but seems to prevent the window from visually being at pixel 1,1 (sometimes) while still fixing the grey background as well as making the maximize experience a little bit cleaner. If anyone knows/can figure out how to unmaximize when dragged while in the maximized state cleanly please let me know! |
This PR adds a transparency button into settings. This has been confirmed tested on Manjaro linux as well as I believe tested on Windows although that should be double checked.
Things of note:
Insrc/main/index.ts
, we manually get the replugged settings. This is needed in order for the launcher to know whether to launch supporting transparency or not. This should be moved elsewhere or done differently however I would like some input on it.Currently there is not translation key forREPLUGGED_SETTINGS_TRANSPARENT
orREPLUGGED_SETTINGS_TRANSPARENT_DESC
. After speaking with @asportnoy, we determined that the various issues with having transparency should be noted per platform instead of all together as they were pre-swc.The settings is currently under advanced settings, however I suppose there is no reason for this to be and it should be moved out and into the general settings.If anyone encounters any bugs with this please let me know!